Re: cvs commit: src/release Makefile src/share/man/man7 release.7

[ Available lists | Index of cvs-all | Month of Jul 2003 | Week of 25 Jul 2003 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Ruslan Ermilov <ru@FreeBSD.org>
Date
25 Jul 2003 14:19:12
Subject
Re: cvs commit: src/release Makefile src/share/man/man7 release.7
Message-ID
20030725211902.GE34677@sunbay.com


[ Hide this part ]
On Fri, Jul 25, 2003 at 09:29:52AM -0700, David O'Brien wrote:
> On Fri, Jul 25, 2003 at 04:00:41PM +0300, Ruslan Ermilov wrote:
> > Index: Makefile
> > ===================================================================
> > RCS file: /home/ncvs/src/release/Makefile,v
> > retrieving revision 1.798
> > diff -u -r1.798 Makefile
> > --- Makefile 25 Jul 2003 08:55:51 -0000 1.798
> > +++ Makefile 25 Jul 2003 12:58:42 -0000
> > @@ -1087,7 +1087,11 @@
> > @echo "echo Please insert MFS root floppy and press enter:" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > @echo "read" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > .endif
> > +.if defined(FDSIZE) && ${FDSIZE} == "SMALL"
> > + @echo "load -t mfs_root /mfsroot-small" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > +.else
> > @echo "load -t mfs_root /mfsroot" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
> > +.endif
>
> Can we *PLEASE* stop this .ifdef maze? Why not set ${MFSROOT_NAME} much
> higher up and have a single
> @echo "load -t mfs_root ${MFSROOT_NAME}" >> ${RD}/image.${FSIMAGE}/boot/loader.rc
>
Feel free to.


Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software Ltd,
ru@FreeBSD.org FreeBSD committer


[ Show this part (application/pgp-signature) ]

Elapsed time: 0.246 seconds