Re: cvs commit: src/sys/dev/ata atapi-cd.c

[ Available lists | Index of cvs-all | Month of Oct 2005 | Week of 10 Oct 2005 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Poul-Henning Kamp <phk@phk.freebsd.dk>
Date
10 Oct 2005 10:12:21
Subject
Re: cvs commit: src/sys/dev/ata atapi-cd.c
Message-ID
13707.1128939139@critter.freebsd.dk


[ Hide this part ]
In message <20051010101013.GB3975@garage.freebsd.pl>, Pawel Jakub Dawidek write
s:
>
>On Mon, Oct 10, 2005 at 11:06:49AM +0200, S?ren Schmidt wrote:
>+> On 09/10/2005, at 23:11, Peter Edwards wrote:
>+>
>+> Why did you ask me to review this when you just committed it anyway ?
>+>
>+> As I said I'm not sure this is the right way to fix this..
>
>It seems to be right. I do it in my GEOM classes to handle g_clone_bio()
>failures better. So the only objection I may have is that it could be
>done a bit cleaner:

Please see geom_disk.c

--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


Elapsed time: 0.144 seconds