Re: cvs commit: src/sys/dev/em if_em.c

[ Available lists | Index of cvs-all | Month of Aug 2006 | Week of 23 Aug 2006 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
John Polstra <jdp@polstra.com>
Date
23 Aug 2006 03:54:47
Subject
Re: cvs commit: src/sys/dev/em if_em.c
Message-ID
XFMail.20060822205444.jdp@polstra.com


[ Hide this part ]
On 23-Aug-2006 Pyun YongHyeon wrote:
> On Tue, Aug 22, 2006 at 07:23:33PM +0400, Gleb Smirnoff wrote:
> I think that problem is different one. That problem happens when
> interrupt is shared with other devices. In these configuration
> em(4) misses lots of Tx completion interrupts and devices that
> use the shared interrupt stop working in the long run.
> It seems that debug.mpsafenet=0 mitigate the issue.
>
> > So I think there is a problem in FreeBSD or driver, not in chip.
> >
> Agreed. If my memory serve me right it introduced right after
> switching to taskqueue(9) in interrupt handling(rev, 1.98).

I was wondering about something in connection with this. The em
interrupt handler is now a "fast" handler, but the interrupt is still
allocated with bus_alloc_resource_any(..., RF_SHAREABLE). If I
remember correctly, fast interrupts cannot be shared. So, isn't it
wrong to allocate the interrupt with RF_SHAREABLE?

John


Elapsed time: 0.163 seconds