Re: cvs commit: src/lib/libc/locale utf8.c

[ Available lists | Index of cvs-all | Month of Nov 2007 | Week of 1 Nov 2007 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Bruce Evans <brde@optusnet.com.au>
Date
1 Nov 2007 12:33:52
Subject
Re: cvs commit: src/lib/libc/locale utf8.c
Message-ID
20071101034838.H4676@delplex.bde.org


[ Hide this part ]
On Wed, 31 Oct 2007, Bruce Evans wrote:

> __mb_sb_limit is extern int, so the ABI breakage was obvious. If it
> had been a compile-time constant with the usual ${CFLAGS} but not a
> constant with -O0, of if the constant depended on ${CFLAGS} or changed
> with __FreeBSD_version, then the problem would have been less obvious.
>
> Now the limit is spelled 128, so it really is constant and won't cause
> problems unless the constant changes.
>
> _ctype.h still declares __mb_sb_limit but now doesn't use it.
> ...

Oops, I didn't realize at first that you only changed it to 128 in one
place. Changing it in only one place (which affects little more than
isdigit()) hardly seems worth it. It leaves the ABI problem, and the
optimization is tiny.

Bruce


Elapsed time: 0.189 seconds