Re: cvs commit: src/sys/i386/isa if_ed.c

[ Available lists | Index of cvs-all | Month of Oct 1998 | Week of 26 Oct 1998 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Date
26 Oct 1998 00:16:03
Subject
Re: cvs commit: src/sys/i386/isa if_ed.c
Message-ID
199810260608.HAA01467@labinfo.iet.unipi.it


[ Hide this part ]
>
> >luigi 1998/10/25 03:25:59 PST
> >
> > Modified files: (Branch: RELENG_2_2)
> > sys/i386/isa if_ed.c
> > Log:
> > Fix two problems which can occur with poor cabling:
> > 1) the routine to compute length for non-std packets (too short
> > or too long) was off by 256 in almost all cases.
> > 2) fixing the above triggered a bug in the bridging code causing
> > ed_ring_copy to be called with a negative length -> panic.
> > It is unlikely that you see the problem unless you use promisc mode,
> > bridging and poor cabling.
>
> This should not have been committed to the 2.2 branch first.

It's a bugfix, not a feature, and the bug is very specific to 2.2
because there is no bridging yet in 3.0, thus i doubt the problem
can occur. So i figured out it was more
urgent to fix 2.2

as soon as i can get my 3.0 machine up i will patch that as well.

cheers
luigi
-----------------------------+--------------------------------------
Luigi Rizzo | Dip. di Ingegneria dell'Informazione
email: luigi@iet.unipi.it | Universita' di Pisa
tel: +39-50-568533 | via Diotisalvi 2, 56126 PISA (Italy)
fax: +39-50-568522 | http://www.iet.unipi.it/~luigi/
_____________________________|______________________________________

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message


Elapsed time: 0.086 seconds