Hello,
Thank you for comments.
On 07/03/2011 02:33 AM, Doug Barton wrote:
> Overall this looks good, just 2 small comments. It's not clear why it
> uses:
>
> # REQUIRE: DAEMON
> # BEFORE: LOGIN
>
> Instead of just
>
> # REQUIRE: LOGIN
>
> like most ports scripts do.
Probably my copypaste from some other script. Better to replace with
REQUIRE: LOGIN.
> Also the default empty assignment for _flags is neither necessary or
desirable.
Agree. Do i need to submit PR to fix this or you can do it without it?