On 3 July 2011 13:07, Alex Samorukov <email@example.com> wrote:
> Thank you for comments.
> On 07/03/2011 02:33 AM, Doug Barton wrote:
>> Overall this looks good, just 2 small comments. It's not clear why it
>> # REQUIRE: DAEMON
>> # BEFORE: LOGIN
>> Instead of just
>> # REQUIRE: LOGIN
>> like most ports scripts do.
> Probably my copypaste from some other script. Better to replace with
> REQUIRE: LOGIN.
>> Also the default empty assignment for _flags is neither necessary or
> Agree. Do i need to submit PR to fix this or you can do it without it?
PR is probably best so it doesn't get lost in the mailing list.