RE: cvs commit: src/sys/alpha/alpha clock.c

[ Available lists | Index of cvs-all | Month of Aug 2001 | Week of 1 Aug 2001 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
John Baldwin <jhb@FreeBSD.org>
Date
1 Aug 2001 13:31:53
Subject
RE: cvs commit: src/sys/alpha/alpha clock.c
Message-ID
XFMail.010801132308.jhb@FreeBSD.org

In reply to
Replies

[ Hide this part ]
 
On 01-Aug-01 Matt Jacob wrote:
> mjacob 2001/08/01 12:40:11 PDT
>
> Modified files:
> sys/alpha/alpha clock.c
> Log:
> Don't initialize a clock twice (it's not a function of number of
> cpus).

Erm, that's not what that is there for. It is there because the clock is not
safe for SMP use. I.e., we only use that timecounter in a UP machine. We
don't call cpu_initclocks() multiple times. However, on the alpha we always
call hardclock() (and thus tc_windup()) on the boot CPU, thus it _might_ be
safe for us to use this timecounter on SMP systems. In any case,
cpu_initclocks() is only called once, so the 'once' variable is bogus. Please
revert that part for now.

--

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Elapsed time: 0.127 seconds