Delivered-To: cvs-all@freebsd.org Received: from mail.wrs.com (unknown-1-11.windriver.com [147.11.1.11]) by hub.freebsd.org (Postfix) with ESMTP id 18E8037B403; Wed, 1 Aug 2001 13:31:46 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@[147.11.46.217]) by mail.wrs.com (8.9.3/8.9.1) with ESMTP id NAA29129; Wed, 1 Aug 2001 13:31:45 -0700 (PDT) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200108011940.f71JeBT28007@freefall.freebsd.org> Date: Wed, 01 Aug 2001 13:23:08 -0700 (PDT) From: John Baldwin To: Matt Jacob Subject: RE: cvs commit: src/sys/alpha/alpha clock.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 01-Aug-01 Matt Jacob wrote: > mjacob 2001/08/01 12:40:11 PDT > > Modified files: > sys/alpha/alpha clock.c > Log: > Don't initialize a clock twice (it's not a function of number of > cpus). Erm, that's not what that is there for. It is there because the clock is not safe for SMP use. I.e., we only use that timecounter in a UP machine. We don't call cpu_initclocks() multiple times. However, on the alpha we always call hardclock() (and thus tc_windup()) on the boot CPU, thus it _might_ be safe for us to use this timecounter on SMP systems. In any case, cpu_initclocks() is only called once, so the 'once' variable is bogus. Please revert that part for now. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message