Overall this looks good, just 2 small comments. It's not clear why it uses:
# REQUIRE: DAEMON
# BEFORE: LOGIN
Instead of just
# REQUIRE: LOGIN
like most ports scripts do. Also the default empty assignment for _flags
is neither necessary or desirable.
hth,
Doug
On 07/02/2011 06:23, Martin Wilke wrote:
> miwi 2011-07-02 13:23:32 UTC
>
> FreeBSD ports repository
>
> Modified files:
> sysutils/atop Makefile distinfo
> sysutils/atop/files atop.in
> Added files:
> sysutils/atop/files pkg-message.in
> Log:
> - Update to to 1.26.b4
>
> PR: 158591 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=158591
> Submitted by: maintainer
>
> Revision Changes Path
> 1.2 +4 -1 ports/sysutils/atop/Makefile
> 1.2 +2 -2 ports/sysutils/atop/distinfo
> 1.2 +17 -3 ports/sysutils/atop/files/atop.in
> 1.1 +21 -0 ports/sysutils/atop/files/pkg-message.in (new)
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/Makefile.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/distinfo.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/files/atop.in.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/atop/files/pkg-message.in
>
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/