Re: cvs commit: ports/Mk bsd.cmake.mk

[ Available lists | Index of cvs-ports | Month of Dec 2011 | Week of 9 Dec 2011 | Raw email | View thread | Wrap long lines | Reply ]
From
Dmitry Marakasov <amdmi3@amdmi3.ru>
Date
9 Dec 2011 15:50:02
Subject
Re: cvs commit: ports/Mk bsd.cmake.mk
Message-ID
20111209154940.GA77124@hades.panopticon


[ Hide this part ]
* Max Brazhnikov (makc@issp.ac.ru) wrote:

> > > Remove CMAKE_USE_PTHREAD.
> > >
> > > This has been in area51 since April, and discussions with makc
> > > indicate this was only needed when we supported FreeBSD < 7.
> > >
> > > Approved by: avilla (mentor), portmgr (tabthorpe)
> > > Feature safe: yes
> > >
> > > Revision Changes Path
> > > 1.13 +1 -15 ports/Mk/bsd.cmake.mk
> >
> > This has broken at least devel/bullet. This is not feature safe at all.
>
> Can you show the build log?

http://people.freebsd.org/~amdmi3/bullet_default.log

with LDFLAGS=-pthread it builds fine:

http://people.freebsd.org/~amdmi3/bullet_ldflags.log

Likely that's a correct way to fix it as bullet CMakeLists.txt
doesn't do any attempts to detect/use thread libs, however the
point is that cited commit is not safe and may touch more ports.

--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru


Elapsed time: 0.172 seconds