Re: cvs commit: src/contrib/pf/pfctl pfctl_parser.c

[ Available lists | Index of cvs-src | Month of Jun 2004 | Week of 18 Jun 2004 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Maxime Henrion <mux@freebsd.org>
Date
18 Jun 2004 14:32:12
Subject
Re: cvs commit: src/contrib/pf/pfctl pfctl_parser.c
Message-ID
20040618143127.GP9228@elvis.mu.org


[ Hide this part ]
Dag-Erling Sm?rgrav wrote:
> Max Laier <mlaier@FreeBSD.org> writes:
> > Log:
> > Fix printing of u_int64_t with a cast to unsigned long long.
>
> The correct fix is to cast it to uintmax_t and print it with %ju.

Using %llu and a cast to (unsigned long long) is as correct as using
uintmax_t and %ju because the C99 standard says that "long long" is at
least 64-bit wide. We generally use {u,}intmax_t in FreeBSD because
it works in more cases, but in that case we can't because OpenBSD
doesn't have intmax_t.

Cheers,
Maxime


Elapsed time: 0.194 seconds