Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk

[ Available lists | Index of cvs-src | Month of Sep 2006 | Week of 13 Sep 2006 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
David O'Brien <obrien@FreeBSD.org>
Date
13 Sep 2006 23:58:12
Subject
Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk
Message-ID
20060913235810.GA87164@dragon.NUXI.org


[ Hide this part ]
On Wed, Sep 13, 2006 at 01:32:11PM -1000, Juli Mallett wrote:
> [ cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk ]
> > When building WITHOUT_ASSERT_DEBUG, we need to disable -Werror as its easy
> > to see "warning: unused variable `foo'".
>
> I think it might be a better idea to -Wno-unused, since the only sorts of
> warnings one wants to ignore building NDEBUG are the variables which are
> otherwise unused.

Hum.. I assumed that WITHOUT_ASSERT_DEBUG was a rare case and used as
part of producing a production release where one knows /usr/src builds
as-usual. -Wno-unused would scratch this itch, but we need to find a way
to codify it so that we're not putting GCC options into share/mk. I
guess make a NO_WUNUSED knob.

--
-- David (obrien@FreeBSD.org)


Elapsed time: 0.133 seconds