Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c

[ Available lists | Index of cvs-src | Month of Jun 2007 | Week of 20 Jun 2007 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Alfred Perlstein <alfred@freebsd.org>
Date
20 Jun 2007 02:04:35
Subject
Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c
Message-ID
20070620020344.GI98795@elvis.mu.org


[ Hide this part ]
* Maxim Sobolev <sobomax@FreeBSD.org> [070619 16:28] wrote:
> Kris Kennaway wrote:
> >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote:
> >>Kris Kennaway wrote:
> >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote:
> >>>>I have made the following patch to bring style(9) back and make code
> >>>>more readable. Do you guys want to run it on bento or could I just
> >>>>check it in?
> >>>>
> >>>>http://sobomax.homeunix.org/~sobomax/deps.c.diff
> >>>Is md5 checksum the same before/after?
> >>Well, it has some trivial non-whitespace changes.
> >
> >whitespace in source does not show up in the binary.
>
> Please re-read my message. It has NON-whitespace changes as well.
>
> -Maxim

lol.. he means does the resulting binary have the same md5?

if it's just style changes, then it should.

also, you missed a non-style conformant function.

void list_deps(const char *pkgname, char **pkgs, char *listed,

that should be:

void
list_deps

--
- Alfred Perlstein


Elapsed time: 0.112 seconds