On Thu, Jul 10, 2008 at 04:58:05PM -0700, Peter Wemm wrote:
> On Thu, Jul 10, 2008 at 4:37 PM, David O'Brien <email@example.com> wrote:
> > On Thu, Jul 10, 2008 at 10:35:35AM -0700, Peter Wemm wrote:
> >> On Thu, Jul 10, 2008 at 9:35 AM, David E. O'Brien <firstname.lastname@example.org> wrote:
> >> > Author: obrien
> >> > Date: Thu Jul 10 16:35:57 2008
> >> > New Revision: 180431
> >> > URL: http://svn.freebsd.org/changeset/base/180431
> >> >
> >> > Log:
> >> > Allow 'elf_file_t' to be used in a wider scope.
> >> >
> >> > Modified:
> >> > head/sys/kern/link_elf.c
> >> > head/sys/sys/link_elf.h
> >> This really was intentional. elf_file_t was supposed to be opaque and
> >> changeable. What do you need this for?
> > Juniper needs to be able to call functions in the loadable modules before
> > the modules are actually linked into the kernel. This will be used to
> > call platform specific initialization functions early in the bootup
> > process. Will also need un-static link_elf_preload_parse_symbols,
> > parse_dynamic, symbol_name, link_elf_lookup_symbol,
> > link_elf_symbol_values.
> I think you should leave it in Juniper's tree for a tad longer:
> ../../../kern/link_elf_obj.c:88: error: redefinition of 'struct elf_file'
> ../../../kern/link_elf_obj.c:119: error: redefinition of typedef 'elf_file_t'
> ../../../sys/link_elf.h:133: error: previous declaration of
> 'elf_file_t' was here
What arch are you building on? I built i386 LINT with this change. So I
need some help reproducing the build break.
-- David (obrien@FreeBSD.org)