Re: Need a code review

[ Available lists | Index of freebsd-arch | Month of Aug 2008 | Week of 7 Aug 2008 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Oleksandr Tymoshenko <gonzo@freebsd.org>
Date
7 Aug 2008 14:59:32
Subject
Re: Need a code review
Message-ID
489B08F6.8060605@freebsd.org


[ Hide this part ]
Dag-Erling Smrgrav wrote:
> "M. Warner Losh" <imp@bsdimp.com> writes:
>> http://people.freebsd.org/~gonzo/mips2/libpam.diff
>
> This won't work. Your patch unconditionally sets NO_STATIC_MODULES
> which will result in a non-functional libpam.a (the modules will be
> built into the library, but without any of the glue that allows the
> library to find them) not just on mips, but on all other platforms.

openpam detects static modules build using cpp(1) condition:
#if defined(__GNUC__) && !defined(__PIC__) && !defined(NO_STATIC_MODULES)
The problem is that gcc MIPS option -mabi-calls assumes -fpic for both
static and dynamic builds. So the question is: would defining
NO_STATIC_MODULES for MIPS be enough or it should be addressed
upstream?

PS NetBSD stumbled upon it too:
http://mail-index.netbsd.org/port-sgimips/2008/01/29/msg000058.html

--
gonzo

Elapsed time: 0.234 seconds