Re: [rfc] removing/conditionalising WERROR= in Makefiles

[ Available lists | Index of freebsd-arch | Month of Dec 2011 | Week of 27 Dec 2011 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Philip Paeps <philip@freebsd.org>
Date
27 Dec 2011 10:42:03
Subject
Re: [rfc] removing/conditionalising WERROR= in Makefiles
Message-ID
20111227010449.GA6244@twoflower.paeps.cx


[ Hide this part ]
On 2011-12-26 10:10:40 (+0000), Alexander Best <arundel@freebsd.org> wrote:
> i grep'ed through src/sys and found several places where WERROR= was set in
> order to get rid of the default -Werror setting. i tried to remove those
> WERROR= overrides from any Makefile, where doing so did not break tinderbox.
>
> in those cases, where it couldn't be completely removed, i added conditions to
> only set WERROR= for the particular achitecture or compiler, where tinderbox
> did not suceed without the WERROR=.

Wouldn't it be better to set WARNS=x rather than WERROR
code has bugs, it breaks tinderbox" whereas WARNS=x says "this code has the
following kind of bugs which break tinderbox".

Possibly wrapped in an architecture-test where appropriate.

- Philip

--
Philip Paeps
Senior Reality Engineer
Ministry of Information

Elapsed time: 0.278 seconds