Re: connect() bug found and fixed (uninitialized pointer)

[ Available lists | Index of freebsd-bugs | Month of Jun 1995 | Week of 8 Jun 1995 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
David Greenman <davidg@Root.COM>
Date
8 Jun 1995 19:56:25
Subject
Re: connect() bug found and fixed (uninitialized pointer)
Message-ID
199506090256.TAA00249@corbin.Root.COM

In reply to

[ Hide this part ]
>    In case Dima didn't get this off to you, there's a bug in
> netinet/tcp_usrreq.c: tcp_connect()... the ifaddr is left
> uninitialized in the case where in_pcbladdr() fails. The fix
> is to check the error code from in_pcbladdr() and to return
> it rather then fall through to the remaining code if it comes
> back non-zero.
>
> I stuck a printf() in there to catch the condition as well just to
> see how often it occured... got about a hit every 10 minutes
> on our (very busy) FTP/WWW server from ftpd.

Interesting...I'll have a look. Want to send me a diff for how you think it
should be fixed?

> Gotta quick question for you guys too: Is it safe to create
> UFS partitions greater then 2GB ?

Yes. Walnut Creek's news server has a 9GB drive (w/single partition) for
it's spool/news, and has been working fine for a month or more.

-DG


Elapsed time: 0.108 seconds