Anton Berezin <firstname.lastname@example.org> writes:
> Bruce Evans <email@example.com> writes:
> > >Can you also look at bin/8164 (``repquota incorrectly reports quotas
> > >larger than 4Gbytes'')? It has fixes in almost the same lines of code
> > >and it seems nobody had a look at it.
> > I read the PR mail but don't have time to test it.
> > I don't understand why your fix is necessary and not a no-op. There
> > is no overflow at 4G because everything is promoted to off_t.
> Oh, yes. The quotas are working perfectly alright. The front ends
> (edquota - bin/8163 and repquota - bin/8164) do not. One has no means
> to _set_ large quotas, at least not with edquota, and no means to
> _see_ large quotas (at least not with repquota).
Oh well. I misunderstood your argument. Inspite of off_t promoting,
this fix is quite neccessary for the following reason:
the quota size expressed in device blocks is first converted to bytes
(this is where overflow occurs; it occurs - try it yourself) and then
is divided by 1024 to obtain kilobytes. The same applies to edquota:
it first multiplies the kilobytes by 1024 and then converts to device
So currently it simply does not work. The first person in need to set
larger quotas was destined to find and fix this. :-)
Anton Berezin <firstname.lastname@example.org>
The Protein Laboratory, University of Copenhagen
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message