Re: call for bge(4) testers

[ Available lists | Index of freebsd-current | Month of Aug 2006 | Week of 22 Aug 2006 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Oleg Bulyzhin <oleg@freebsd.org>
Date
22 Aug 2006 20:43:52
Subject
Re: call for bge(4) testers
Message-ID
20060822204342.GA4943@lath.rinet.ru


[ Hide this part ]
On Tue, Aug 22, 2006 at 02:44:34PM +0200, Michael Reifenberger wrote:
> On Tue, 22 Aug 2006, Pyun YongHyeon wrote:
> ...
> >I'm not familiar with vge(4) and don't have hardwares supported by
> >vge(4). Because vge(4) supports a kind of interrupt moderation, there
> >is a possiblity to have the same issue seen on em(4).
> >If you want my blind patch I can send a patch for you.
> >
> Yes, please!
> I can test it (on RELENG_6 though).

I have an idea why those timeouts can happen. Could you please test
attached patch? It may help (or may not). Anyway would be fine
to know results.

>
> Bye/2
> ---
> Michael Reifenberger, Business Development Manager SAP-Basis, Plaut
> Consulting
> Comp: Michael.Reifenberger@plaut.de | Priv: Michael@Reifenberger.com
> http://www.plaut.de | http://www.Reifenberger.com
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

--
Oleg.



[ Hide this part ]
Index: if_vge.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/vge/if_vge.c,v
retrieving revision 1.24
diff -u -r1.24 if_vge.c
--- if_vge.c 14 Feb 2006 12:44:56 -0000 1.24
+++ if_vge.c 22 Aug 2006 20:35:23 -0000
@@ -2129,8 +2129,10 @@
struct mii_data *mii;

sc = ifp->if_softc;
+ VGE_LOCK(sc);
mii = device_get_softc(sc->vge_miibus);
mii_mediachg(mii);
+ VGE_UNLOCK(sc);

return (0);
}
@@ -2147,11 +2149,13 @@
struct mii_data *mii;

sc = ifp->if_softc;
+ VGE_LOCK(sc);
mii = device_get_softc(sc->vge_miibus);

mii_pollstat(mii);
ifmr->ifm_active = mii->mii_media_active;
ifmr->ifm_status = mii->mii_media_status;
+ VGE_UNLOCK(sc);

return;
}



Elapsed time: 0.183 seconds