Re: Freebsd 3.0 current fails ipfilter 3.2b8 build (fwd)

[ Available lists | Index of freebsd-hackers | Month of Oct 1997 | Week of 15 Oct 1997 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Brian Somers <brian@awfulhak.org>
Date
15 Oct 1997 15:53:51
Subject
Re: Freebsd 3.0 current fails ipfilter 3.2b8 build (fwd)
Message-ID
199710152223.XAA18393@awfulhak.demon.co.uk

In reply to

[ Hide this part ]
> All the "_var.h" files contain variables who'se scope is within the
> kernel only. The only exception is LKMs which should define KERNEL.
> I don't know who did this, (I see in the logs it was garrett)
> but the idea is simply to make it more obvios when you are
> doing the WRONG thing
> and including kernel private variables (that are subject to change,
> and not part of the API) .
>
> julian

But "struct ifnet" is decl'd in if_var.h and referenced from many
other files. It's therefore necessary to #include if_var.h before
including the likes of if_ether.h or in_var.h.

> Darren Reed wrote:
> >
> > Before I commit a change that will fix this absurdity to FreeBSD (i.e.
> > include if_var.h from if.h), perhaps someone can explain why this
> > (seemingly needless) change was made.

I'd certainly welcome the ``fix'', but I suspect you'll have some
opposition.

--
Brian <brian@Awfulhak.org>, <brian@FreeBSD.org>, <bri@OpenBSD.org>
<http://www.Awfulhak.org>
Don't _EVER_ lose your sense of humour....




Elapsed time: 0.120 seconds