Re: tiny patch to pkg_add

[ Available lists | Index of freebsd-hackers | Month of Sep 2001 | Week of 7 Sep 2001 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
David O'Brien <obrien@freebsd.org>
Date
7 Sep 2001 16:22:47
Subject
Re: tiny patch to pkg_add
Message-ID
20010907162242.A16949@dragon.nuxi.com

References to
Referenced by

[ Hide this part ]
On Fri, Sep 07, 2001 at 03:04:16PM -0700, Bill Swingle wrote:
> So this represents my most significant effort to date to fix something
> in C. It took me far too long to identify where the one line fix needed
> to go and even longer to figure out how to do it in C.
>
> Here's the problem that this fixes:

This was introduced in rev 1.38:

and replace a big if..then..else construct
to determine the package download directory with a lookup table.

I am very tempted to back this part out. This "better implimentation"
has now had two logic bugs. I wrote that "big if..then..else contstruct"
so that the code would be *so* simple my simple my 1st quarter freshman
students (back when I TA'ed) could understand it. I did it that way
because I got tired of committers constantly breaking -r.

--
-- David (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message



Elapsed time: 0.487 seconds