"David O'Brien" wrote:
| On Fri, Sep 07, 2001 at 03:04:16PM -0700, Bill Swingle wrote:
| > So this represents my most significant effort to date to fix something
| > in C. It took me far too long to identify where the one line fix needed
| > to go and even longer to figure out how to do it in C.
| >
| > Here's the problem that this fixes:
|
| This was introduced in rev 1.38:
|
| and replace a big if..then..else construct
| to determine the package download directory with a lookup table.
|
| I am very tempted to back this part out. This "better implimentation"
| has now had two logic bugs. I wrote that "big if..then..else contstruct"
| so that the code would be *so* simple my simple my 1st quarter freshman
| students (back when I TA'ed) could understand it. I did it that way
| because I got tired of committers constantly breaking -r.
Simple and correct is always better than clever and wrong. I'd
be strongly in favour of backing it out.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message