The following reply was made to PR ports/69636; it has been noted by GNATS.
From: "Volker Stolz" <vs@freebsd.org>
To: freebsd-gnats-submit@freebsd.org, fernan@iib.unsam.edu.ar
Cc:
Subject: Re: ports/69636: [new port] biology/blast
Date: Tue, 27 Jul 2004 15:01:49 +0200
I) Please use 'portlint':
blast@menelaos [14:32:09]> portlint -A
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [21]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [22]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [23]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [24]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [25]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [26]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist [27]: consider using DOCSDIR macro
WARN: /usr/tmp/FreeBSD/blast/pkg-plist: Both ``%%PORTDOCS%%@dirrm
%%DOCSDIR%%'' and ``%%PORTDOCS%%@unexec %D/%%DOCSDIR%% 2>/dev/null ||
true'' are missing. At least one should be used.
^^^^ These indeed look like packing errors. See
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-documentation.html
Additionally to PORTDOCS, you might also want to use DATADIR.
WARN: Makefile: "DISTNAME" has to appear earlier.
WARN: Makefile: "RESTRICTED" found. do not forget to update ports/LEGAL.
OK.
WARN: /usr/tmp/FreeBSD/blast/pkg-message: possible use of absolute
pathname "/usr/tmp/share/blast".
WARN: /usr/tmp/FreeBSD/blast/pkg-message: possible use of absolute
pathname "/etc".
WARN: /usr/tmp/FreeBSD/blast/pkg-message: possible use of absolute
pathname "/usr/tmp/share/blast...".
This is because your pkg-message-handling is faulty, please see e.g.
net/xpvm on how to replace a
string in your pkg-message.
0 fatal errors and 13 warnings found.
II) In do-install:
${CHMOD} a-r ${PREFIX}/bin/blasta -- does this make sense?
You can't CHOWN a symlink.
III) There's already x11/blast -- in the case that there'll ever be a
binary package, you have use LATEST_LINK to avoid a conflict.
IV) Naming: "blast" is pretty generic -- hwo about "wu-blast" instead?
V) Improvements
Half of the files in the plist are already in the Makefile. You could use
PORTDOCS/PLIST_FILES to reduce a bit the redundancy
Cheers, Volker