ports/145447: noticed a useless cat(1) in install.sh for ports

[ Available lists | Index of freebsd-ports-bugs | Month of Apr 2010 | Week of 7 Apr 2010 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Stefan Kuttler <u@netbeisser.de>
Date
7 Apr 2010 02:00:15
Subject
ports/145447: noticed a useless cat(1) in install.sh for ports
Message-ID
201004070153.o371rOjf061867@www.freebsd.org


[ Hide this part ]
 
>Number: 145447
>Category: ports
>Synopsis: noticed a useless cat(1) in install.sh for ports
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Apr 07 02:00:14 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Stefan Kuttler
>Release: FreeBSD 8.0-RELEASE #0
>Organization:
nc.netbeisser.de
>Environment:
FreeBSD .localdomain 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Sat Nov 21 15:48:17 UTC 2009 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
noticed a useless cat(1) in install.sh for ports:

- cat ports.tgz | tar --unlink -xpzf - -C ${DESTDIR}/usr
+ tar --unlink -xpzf ports.tgz -C ${DESTDIR}/usr

this works well for bsdtar.
>How-To-Repeat:
it works even without cat:

# setenv DESTDIR /
# tar --unlink -xpzf ports.tgz -C ${DESTDIR}/usr
# echo $?
0

>Fix:
remove cat(1) from install.sh

>Release-Note:
>Audit-Trail:
>Unformatted:


Elapsed time: 0.070 seconds