The following reply was made to PR ports/150235; it has been noted by GNATS.
From: Alex Samorukov <samm@os2.kiev.ua>
To: Doug Barton <dougb@FreeBSD.org>
Cc: Garrett Wollman <wollman@FreeBSD.org>, bug-followup@FreeBSD.org,
developers@FreeBSD.org
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Mon, 06 Sep 2010 00:06:54 +0200
On 09/05/2010 11:44 PM, Doug Barton wrote:
> On 09/05/2010 12:28 PM, Alex Samorukov wrote:
>> Your proposed patch will break smartmontools functionality - thats why
>> i`m not able to accept it.
>
> It's not at all clear to me why developers@ is cc'ed on these
> messages, but since we are ...
>
> Alex,
>
> Can you please explain why the change Garrett is suggesting will break
> anything? According to his PR all the headers that smartmontools needs
> are included in /usr/include. Is that not the case?
It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h to
work with cciss devices on FreeBSD. configure script checks if this file
is exists on the compile time, and if its not - does not compile cciss
support in the smartmontools.
If user will try to use cciss driver in this case - smartmontools will
display an error:
"CCISS support is not available in this build of smartmontools,\n"
"/usr/src/sys/dev/ciss/cissio.h was not available at build time.\n\n");
>
> What you've been told (that we prefer not to have userland tools
> include /usr/src directly) is accurate, so the burden of proof is on
> you to explain why it's necessary in this case. The fact that other
> ports may or may not do this is not relevant here.
>
I hope my explanation is clear.