On Jul 29, 2011, at 7:24 PM, Andrew Boyer wrote:
> The error variable is returned uninitialized if no error occurs. I noticed because 'mfiutil -de show drives' started returning 1 for no apparent reason when I synced up to stable/8.
>
> I looked through the rest of mfiutil and didn't see any more cases like this one.
>
John found that a couple of days ago; it's likely it's in the re@ queue for committing and fixing or has been fixed in head already.
> -Andrew
>
> Index: usr.sbin/mfiutil/mfi_show.c
> ===================================================================
> --- usr.sbin/mfiutil/mfi_show.c (revision 224494)
> +++ usr.sbin/mfiutil/mfi_show.c (working copy)
> @@ -470,7 +470,7 @@
> struct mfi_pd_list *list;
> struct mfi_pd_info info;
> u_int i, len, state_len;
> - int error, fd;
> + int error = 0, fd;
>
> if (ac != 1) {
> warnx("show drives: extra arguments");
>
> --------------------------------------------------
> Andrew Boyer aboyer@averesystems.com
>
>
>
>
--
Bjoern A. Zeeb You have to have visions!
Stop bit received. Insert coin for new address family.