When client ids have been run out of, does that put something into a
dangerous state (insecure or crash-prone)? Isn't it better to let the
administrator make the decision of when to reboot the machine?
On Wed, May 20, 2009 at 11:58 AM, Rick Macklem <rmacklem@freebsd.org> wrote:
> Author: rmacklem
> Date: Wed May 20 18:58:07 2009
> New Revision: 192463
> URL: http://svn.freebsd.org/changeset/base/192463
>
> Log:
> Although it should never happen, all the nfsv4 server can do
> when it runs out of clientids is reboot. I had replaced cpu_reboot()
> with printf(), since cpu_reboot() doesn't exist for sparc64.
> This change replaces the printf() with panic(), so the reboot
> would occur for this highly unlikely occurrence.
>
> Approved by: kib (mentor)
>
> Modified:
> head/sys/fs/nfsserver/nfs_nfsdstate.c
>
> Modified: head/sys/fs/nfsserver/nfs_nfsdstate.c
> ==============================================================================
> --- head/sys/fs/nfsserver/nfs_nfsdstate.c Wed May 20 18:45:49 2009 (r192462)
> +++ head/sys/fs/nfsserver/nfs_nfsdstate.c Wed May 20 18:58:07 2009 (r192463)
> @@ -3709,7 +3709,7 @@ nfsrv_nextclientindex(void)
> * In practice, we'll never get here, but the reboot is here,
> * just for fun. (client_index will not wrap around on any real server)
> */
> - printf("you must reboot now\n");
> + panic("nfsv4 server out of clientids");
> return (0); /* Just to shut the compiler up */
> }
>
>