Re: svn: head/sbin/newfs

[ Available lists | Index of svn-src-all | Month of Mar 2010 | Week of 4 Mar 2010 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Maxim Sobolev <sobomax@FreeBSD.org>
Date
4 Mar 2010 05:04:14
Subject
Re: svn: head/sbin/newfs
Message-ID
4B8F3F4B.7020002@FreeBSD.org


[ Hide this part ]
Warner Losh wrote:
> Author: imp
> Date: Wed Mar 3 21:53:25 2010
> New Revision: 204672
> URL: http://svn.freebsd.org/changeset/base/204672
>
> Log:
> Cast these to intmax_t before printing to fix build bustage. Better
> solutions welcome.

Thanks for a quick fix and sorry for the breakage. IMHO you fix's fine,
there is no real reason to use 64-bit quantity anyway, it's just because
expand_number(3) interface is not very well designed and forces anyone
using it stick with that data type. So downsizing from 64-bit to 32-bit
on platforms where intmax_t is 32-bit only (if any) should not be an
issue in real life.

-Maxim

Elapsed time: 0.213 seconds