Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version

[ Available lists | Index of svn-src-all | Month of Apr 2010 | Week of 3 Apr 2010 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Joerg Sonnenberger <joerg@britannica.bec.de>
Date
3 Apr 2010 11:42:28
Subject
Re: svn commit: r206043 - in head/usr.sbin/pkg_install: add delete lib version
Message-ID
20100403114055.GC23007@britannica.bec.de

In reply to
Referenced by

[ Hide this part ]
On Sat, Apr 03, 2010 at 04:32:15AM -0700, Garrett Cooper wrote:
> I'm sorry but I'm a little bit confused by this statement: do you
> mean that you're replacing PATH_MAX sized buffers to FILENAME_MAX
> sized buffers? If so this may cause an issue because several of the
> variables used in constructing the file paths in pkg_install aren't
> necessarily correct in overflow cases. We need to avoid introducing
> potential functional flaws with filename truncation like this.

No, I am replacing fixed size buffers with variable size buffers. The
extraction code should generally be able to support arbitrary deep path
names, for the rest the kernel can complain.

Joerg


Elapsed time: 0.212 seconds