Re: svn commit: r228625 - head/usr.bin/csup

[ Available lists | Index of svn-src-all | Month of Dec 2011 | Week of 17 Dec 2011 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net>
Date
17 Dec 2011 21:56:24
Subject
Re: svn commit: r228625 - head/usr.bin/csup
Message-ID
E64E9703-3032-4AFA-BAA4-BC4552AFC3C7@lists.zabbadoz.net


[ Hide this part ]
 
On 17. Dec 2011, at 21:54 , Dimitry Andric wrote:

> On 2011-12-17 22:32, mdf@FreeBSD.org wrote:
> ...
>>> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the
>>> shared secret, and use long long format to snprintf a time_t.
>> If casting is necessary, style prefers intmax_t or uintmax_t, since
>> those are always wide enough.
>
> I don't see anything about that in style(9), maybe it should be added
> then? In any case, I only changed the %ld format to %lld, because
> time_t is int, long or long long depending on arch. Long long is just
> the widest type required in this case.

time_t is not always int. See sparc64.

--
Bjoern A. Zeeb You have to have visions!
Stop bit received. Insert coin for new address family.



Elapsed time: 0.122 seconds