svn commit: r233961 - head/sys/x86/x86

[ Available lists | Index of svn-src-all | Month of Apr 2012 | Week of 6 Apr 2012 | Raw email | View thread | Wrap long lines | Reply ]
From
Justin T. Gibbs <gibbs@FreeBSD.org>
Date
6 Apr 2012 21:19:29
Subject
svn commit: r233961 - head/sys/x86/x86
Message-ID
201204062119.q36LJTKR026564@svn.freebsd.org


[ Hide this part ]
Author: gibbs
Date: Fri Apr 6 21:19:28 2012
New Revision: 233961
URL: http://svn.freebsd.org/changeset/base/233961

Log:
Fix interrupt load balancing regression, introduced in revision
222813, that left all un-pinned interrupts assigned to CPU 0.

sys/x86/x86/intr_machdep.c:
In intr_shuffle_irqs(), remove CPU_SETOF() call that initialized
the "intr_cpus" cpuset to only contain CPU0.

This initialization is too late and nullifies the results of calls
the intr_add_cpu() that occur much earlier in the boot process.
Since "intr_cpus" is statically initialized to the empty set, and
all processors, including the BSP, already add themselves to
"intr_cpus" no special initialization for the BSP is necessary.

MFC after: 3 days

Modified:
head/sys/x86/x86/intr_machdep.c

Modified: head/sys/x86/x86/intr_machdep.c
==============================================================================
--- head/sys/x86/x86/intr_machdep.c Fri Apr 6 20:34:00 2012 (r233960)
+++ head/sys/x86/x86/intr_machdep.c Fri Apr 6 21:19:28 2012 (r233961)
@@ -525,9 +525,6 @@ intr_shuffle_irqs(void *arg __unused)
return;
#endif

- /* The BSP is always a valid target. */
- CPU_SETOF(0, &intr_cpus);
-
/* Don't bother on UP. */
if (mp_ncpus == 1)
return;


Elapsed time: 0.185 seconds