Re: svn commit: r205626 - head/sys/kern

[ Available lists | Index of svn-src-head | Month of Mar 2010 | Week of 24 Mar 2010 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
John Baldwin <jhb@freebsd.org>
Date
24 Mar 2010 21:13:05
Subject
Re: svn commit: r205626 - head/sys/kern
Message-ID
201003241620.20516.jhb@freebsd.org


[ Hide this part ]
On Wednesday 24 March 2010 3:21:26 pm Bjoern A. Zeeb wrote:
> Author: bz
> Date: Wed Mar 24 19:21:26 2010
> New Revision: 205626
> URL: http://svn.freebsd.org/changeset/base/205626
>
> Log:
> Print the pointer to the lock with the panic message. The previous
> panic: rw lock not unlocked
> was not really helpful for debugging. Now one can at least call
> show lock <ptr>
> form ddb to learn more about the lock.

Hmm, for consistency you may wish to fix similar panic messages in
sx_destroy() and mtx_destroy(). There are many, many other panic messages in
mtx, sx, and rwlock that do not include the lock pointer (though many do
include the file/line which is nearly as useful).

--
John Baldwin

Elapsed time: 0.199 seconds