On Sun, May 16, 2010 at 12:54 PM, Juli Mallett <firstname.lastname@example.org> wrote:
> On Sun, May 16, 2010 at 12:43, Randall Stewart <email@example.com> wrote:
>> Author: rrs
>> Date: Sun May 16 19:43:48 2010
>> New Revision: 208165
>> URL: http://svn.freebsd.org/changeset/base/208165
>> This pushes all of JC's patches that I have in place. I
>> am now able to run 32 cores ok.. but I still will hang
>> on buildworld with a NFS problem. I suspect I am missing
>> a patch for the netlogic rge driver.
>> JC check and see if I am missing anything except your
>> core-mask changes
> This isn't a very good commit message. Commits communicate things
> going forward. A follow-up E-Mail CCing JC would have been a good way
> to chat with him about its completeness. More importantly, though,
> there's just no description of the contents. This is particularly
> frustrating as it's also not broken up into functional chunks very
> well. Given the fact that there are MI changes and pan-MIPS changes
> here it would be nice to see a little more care taken. The changes to
> the MIPS MP code, for instance, I thought we had discussed and decided
> were sub-par and easily made less invasive. I can't comment on the
> RMI-specific stuff except to say that it's an unenumerated jumble of
> VM, networking and SMP changes.
I agree with Juli.
This is especially true with respect to the changes to pmap.c. There
needed to be a companion set of changes to exception.S to undo some of
the changes to the TLB invalid handler that deal with recursive faults
in the TLB miss handler.