Re: svn commit: r210479 - head/usr.bin/grep

[ Available lists | Index of svn-src-head | Month of Jul 2010 | Week of 26 Jul 2010 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Dag-Erling Smørgrav <des@des.no>
Date
26 Jul 2010 09:51:00
Subject
Re: svn commit: r210479 - head/usr.bin/grep
Message-ID
86ocduy3k0.fsf@ds4.des.no


[ Hide this part ]
Gabor Kovesdan <gabor@FreeBSD.org> writes:
> I did run regression testing, the test suite that GNU grep has.

Does that test suite include a test for the bug you fixed? If not,
running it before committing this particular patch was close to useless.

By definition, a regression test is designed to trigger a specific bug
so the developer(s) can make sure it is not reintroduced at some later
point once it's been fixed. Standard procedure is for the developer to
write a regression test *before* fixing the bug, and verifying that the
test fails when run against the unpatched code and succeeds when run
against the patched code.

DES
--
Dag-Erling Smrgrav - des@des.no

Elapsed time: 0.172 seconds