Re: svn commit: r195463 - projects/mesh11s/sys/net80211

[ Available lists | Index of svn-src-projects | Month of Jul 2009 | Week of 9 Jul 2009 | Raw email | View thread | Wrap long lines | Reply | Tag ]
From
Rui Paulo <rpaulo@gmail.com>
Date
9 Jul 2009 08:35:47
Subject
Re: svn commit: r195463 - projects/mesh11s/sys/net80211
Message-ID
BEC0BD8F-D7FD-4324-A149-ADDAFF0816D2@gmail.com

In reply to

[ Hide this part ]
On 9 Jul 2009, at 09:31, Rui Paulo wrote:
> On 8 Jul 2009, at 19:30, Bruce Evans wrote:
>
>> On Wed, 8 Jul 2009, Rui Paulo wrote:
>>
>>> Log:
>>> Revert 195460: gcc does evil things without __packed.
>>
>> Oops, I asked if __packed was really spurious before seeing this.
>>
>> gcc does evil things with __packed (starting with it not being a
>> syntax
>> error).
>>
>> Did it only break on arm?
>
> I didn't have a chance to try other architectures. But possibly, yes.
> For example, sizeof(meshconf_ie) is 23 but, on arm and without
> __packed, it gave me 26 IIRC.

Actually, sizeof(meshconf_ie) should be 25, but on arm
sizeof(meshconf_ie) == 28 (next multiple of 4).
We then decrement 2 from the sizeof in the code, so this gives 26 (the
correct answer would be 23, of course).

--
Rui Paulo


Elapsed time: 0.171 seconds