Pawel Jakub Dawidek wrote:
> On Wed, Dec 22, 2010 at 09:02:22AM +0000, Alexander Motin wrote:
>> Author: mav
>> Date: Wed Dec 22 09:02:22 2010
>> New Revision: 216649
>> URL: http://svn.freebsd.org/changeset/base/216649
>>
>> Log:
>> Implement basic metadata generation check. To be sure that used metadata is
>> up to date - delay volumes creation until we have all disks or timeout
>> expires. This probably obsolete same functionality done at volumes level.
> [...]
>> +static struct intel_raid_conf *
>> +intel_meta_copy(struct intel_raid_conf *meta)
>> +{
>> + struct intel_raid_conf *nmeta;
>> +
>> + nmeta = malloc(meta->config_size, M_MD_INTEL, M_WAITOK | M_ZERO);
>> + memcpy(nmeta, meta, meta->config_size);
>> + return (nmeta);
>> +}
>
> The M_ZERO flag seems to be redundant, as you fill the entire buffer in
> the next line.
Indeed. Thanks. But I am sure it is not the biggest of my problems. :)
--
Alexander Motin